feat: block-kubectl-cp policy #1216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Darkhood148
force-pushed
the
block-kubectl-cp-policy
branch
from
ddfa426 to
15ef878
Compare
|
Hey @JimBugwadia, I am done with all the changes including chainsaw tests. Could you please review it? |
Darkhood148
force-pushed
the
block-kubectl-cp-policy
branch
from
d945dab to
d37184c
Compare
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Darkhood148
force-pushed
the
block-kubectl-cp-policy
branch
from
d37184c to
748dbb4
Compare
|
Hi @Darkhood148 - can you please fix the lint error? https://github.com/kyverno/policies/actions/runs/12899995348/job/36452593199?pr=1216 You will need to re-run the artifacthub ID generator to incorporate changes: https://github.com/kyverno/policies/blob/main/.hack/update-artifacthub-pkg.sh Also, do we need the label check in this policy? I recommend simplifying by removing this. Users can opt-out via exceptions, etc. which seems better from a security perspective. |
Darkhood148
changed the title
Darkhood148
force-pushed
the
block-kubectl-cp-policy
branch
4 times, most recently
from
fbd3c98 to
59142b3
Compare
Signed-off-by: Darkhood148 <ujjwal.sharma9999999@gmail.com>
Darkhood148
force-pushed
the
block-kubectl-cp-policy
branch
from
59142b3 to
12b6514
Compare
|
Hi @JimBugwadia I have done the linting changes and removed the usage of labels. Could you please review the updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
#1169
Description
Created a policy for the mentioned issue i.e. a policy that can block
kubectl cpfor pods with a given labelChecklist