Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infrastructure updates #11

Merged
merged 1 commit into from
Mar 4, 2024
Merged

infrastructure updates #11

merged 1 commit into from
Mar 4, 2024

Conversation

PicoCentauri
Copy link
Contributor

@PicoCentauri PicoCentauri commented Feb 29, 2024

  • enable codecov
  • use github pages for docs
  • update gh actions

📚 Documentation preview 📚: https://meshlode--11.org.readthedocs.build/en/11/

@PicoCentauri PicoCentauri force-pushed the codecov branch 4 times, most recently from 5e1d72e to 06eb5d4 Compare February 29, 2024 17:36
# git clone https://github.com/$GITHUB_REPOSITORY --branch gh-pages gh-pages
# rm -rf gh-pages/.git
# cd gh-pages
- name: put documentation in the website
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the gh-pages branch looks wrong: https://github.com/lab-cosmo/MeshLODE/tree/gh-pages

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be empty, maybe with a .nojekyl and index.html which redirects to latest

@@ -15,32 +15,36 @@ jobs:
# - os: ubuntu-22.04
# python-version: "3.8"
- os: ubuntu-22.04
python-version: "3.11"
python-version: "3.12"
# - os: macos-11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it this commented out by choice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this was a private repo of Michele, where we had to pay for the CI. If we don't have to pay anymore I am happy to enable these tests again.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is still a private repo, we still have to pay for CI I think. @ceriottm do you know about the exact status?

pyproject.toml Outdated
@@ -54,6 +54,8 @@ repository = "https://github.com/lab-cosmo/MeshLODE"
issues = "https://github.com/lab-cosmo/MeshLODE/issues"

[tool.coverage.report]
skip_covered = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
skip_covered = true

I found this to be perturbing when looking at local reports, and it might not include these files on codecov as well

@PicoCentauri PicoCentauri force-pushed the codecov branch 4 times, most recently from 4f433c8 to be955d1 Compare March 1, 2024 16:00
* enable codecov
* use github pages for docs
* update gh actions
@PicoCentauri PicoCentauri merged commit 3a483f7 into main Mar 4, 2024
6 checks passed
@PicoCentauri PicoCentauri deleted the codecov branch March 4, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants