-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MeshPotential calculator #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some first comments on the docs. I will continue later with more detailed. comments.
Co-authored-by: Philip Loche <philip.loche@posteo.de>
…nto potential_calculator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very clean and documentated. I have some comments basically that will help users if the provide wrong shapes of the arrays.
Also, maybe we should also do examples for the FourierSpaceConvolution
and the MeshInterpolator
classes. What do you think?
I have now implemented all the changes that you suggested, apart from keeping the |
I added an example of |
a2f3782
to
e4dbc83
Compare
40d89f8
to
b46cda2
Compare
Hmm I am a bit confused by the failure of the jobs. We haven't touched the files and the GH action service seems to run fine. |
Add a first working version containing:
The code comes with
📚 Documentation preview 📚: https://meshlode--3.org.readthedocs.build/en/3/