Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

658 #663

Merged
merged 7 commits into from
May 11, 2021
Merged

658 #663

merged 7 commits into from
May 11, 2021

Conversation

zDudaHang
Copy link
Contributor

@zDudaHang zDudaHang commented Apr 27, 2021

Part of #657

@zDudaHang zDudaHang linked an issue Apr 27, 2021 that may be closed by this pull request
@vercel vercel bot temporarily deployed to Preview April 27, 2021 22:38 Inactive
@vercel vercel bot temporarily deployed to Preview April 27, 2021 22:49 Inactive
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #663 (4ce3582) into master (25717dd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #663   +/-   ##
=======================================
  Coverage   98.21%   98.22%           
=======================================
  Files         463      464    +1     
  Lines        3871     3882   +11     
  Branches      554      556    +2     
=======================================
+ Hits         3802     3813   +11     
  Misses         55       55           
  Partials       14       14           
Impacted Files Coverage Δ
src/components/PivotTable/Box/Box.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25717dd...4ce3582. Read the comment docs.

Copy link
Contributor

@lucasjoao lucasjoao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tá top! 🚀 Só algumas sugestões e detalhes

} as CSSProperties,

children: {
minHeight: '7.18rem',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a gente não tem um padrão de ser de x em x os espaçamentos? @calistro

src/components/Box/Box.tsx Outdated Show resolved Hide resolved
src/components/Box/Box.stories.tsx Outdated Show resolved Hide resolved
src/components/Box/Box.stories.tsx Outdated Show resolved Hide resolved
src/components/Box/Box.stories.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview April 29, 2021 14:48 Inactive
@vercel vercel bot temporarily deployed to Preview April 29, 2021 14:54 Inactive
@zDudaHang zDudaHang requested a review from lucasjoao April 29, 2021 15:32
Copy link
Contributor

@Andrevmatias Andrevmatias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@fabmatos fabmatos merged commit aedcc48 into master May 11, 2021
@fabmatos fabmatos deleted the 658 branch May 11, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(2) [Pivot table] Box
5 participants