671 [Pivot Table] Droppable #690
Conversation
Codecov Report
@@ Coverage Diff @@
## master #690 +/- ##
==========================================
+ Coverage 98.58% 98.60% +0.01%
==========================================
Files 475 476 +1
Lines 4108 4161 +53
Branches 636 631 -5
==========================================
+ Hits 4050 4103 +53
Misses 58 58
Continue to review full report at Codecov.
|
-> Adding i18n to droppable messages -> Fixing droppable stories -> Adding a check for filterState and handleFilterUpdate props
The change of context happened because we have some doubts about the final result from issue #657. Who use the Bold will call a one component called For now we don't have answers for these questions (suggestions are welcome). I wrote in the issue about this and create a note in the team board too. So these change of context could be rolled back in the future :) |
| const { name, keyState, keyMapping, accept, filter, handleKeyUpdate, onKeyNav } = props | ||
|
|
||
| const locale = useLocale() | ||
|
|
||
| const [{ isOver }, drag] = useDrop({ |
There was a problem hiding this comment.
The logic that throw error in some scenarios isnt more necessary?
There was a problem hiding this comment.
The second check is no longer necessary because DroppableFilter ensures that filterState and handleFilterUpdate must be defined together.
In relation to the first, it remains necessary. I will fix this
Part of #657
closes #671