Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Array view #1570

Merged
merged 5 commits into from
Feb 4, 2025
Merged

[Feat] Array view #1570

merged 5 commits into from
Feb 4, 2025

Conversation

SamFlt
Copy link
Contributor

@SamFlt SamFlt commented Feb 4, 2025

This PR adds the ability to view a raw double array (not managed by a ViSP object) as a matrix, or vector.
This is useful to avoid unecessary copies of NumPy arrays when using them as function inputs.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 77.58621% with 13 lines in your changes missing coverage. Please review.

Project coverage is 54.54%. Comparing base (cae757c) to head (e9fa962).
Report is 91 commits behind head on master.

Files with missing lines Patch % Lines
modules/core/src/math/matrix/vpColVector.cpp 40.00% 3 Missing ⚠️
modules/core/src/math/matrix/vpMatrix.cpp 40.00% 3 Missing ⚠️
modules/core/src/math/matrix/vpRowVector.cpp 50.00% 3 Missing ⚠️
modules/core/include/visp3/core/vpArray2D.h 94.59% 2 Missing ⚠️
modules/core/include/visp3/core/vpColVector.h 50.00% 1 Missing ⚠️
modules/core/include/visp3/core/vpRowVector.h 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1570      +/-   ##
==========================================
+ Coverage   54.01%   54.54%   +0.52%     
==========================================
  Files         441      442       +1     
  Lines       53865    53459     -406     
==========================================
+ Hits        29095    29157      +62     
+ Misses      24770    24302     -468     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

modules/core/include/visp3/core/vpArray2D.h Show resolved Hide resolved
modules/core/include/visp3/core/vpArray2D.h Outdated Show resolved Hide resolved
modules/core/src/math/matrix/vpMatrix_lu.cpp Outdated Show resolved Hide resolved
modules/core/src/math/matrix/vpRowVector.cpp Show resolved Hide resolved
modules/python/bindings/include/core/utils.hpp Outdated Show resolved Hide resolved
modules/python/test/test_numpy_array.py Outdated Show resolved Hide resolved
@fspindle fspindle merged commit 3da0c2b into lagadic:master Feb 4, 2025
85 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants