Laminas\Translator
#128
Merged
Laminas\Translator
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires `laminas/laminas-translator` and extends the shipped interface via `Laminas\I18n\Translator\TranslatorInterface` Signed-off-by: George Steel <george@net-glue.co.uk>
… `laminas/laminas-translator` Signed-off-by: George Steel <george@net-glue.co.uk>
|
AFAIR just having an Interface extending another is not a bc break. 🤔 |
yep, it's only a BC break if the new parent interface adds new methods that weren't there before 👍 |
froschdesign
approved these changes
Jul 2, 2024
This was referenced Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requires
laminas/laminas-translatorand extends the shipped interface viaLaminas\I18n\Translator\TranslatorInterfaceAs a straight copy of the existing interface, there's no BC break, but I guess there is a "technical" BC break because of any change in inheritance.
If this has to go into a major release, it defeats the point of extracting the interface in the first place.