-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: php artisan key:rotate command #54437
Open
tanthammar
wants to merge
8
commits into
laravel:11.x
Choose a base branch
from
tanthammar:rotate-key-cmd
base: 11.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+119
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional thoughts:
|
crynobone
requested changes
Feb 1, 2025
Co-authored-by: Mior Muhammad Zaki <crynobone@gmail.com>
Co-authored-by: Mior Muhammad Zaki <crynobone@gmail.com>
Co-authored-by: Mior Muhammad Zaki <crynobone@gmail.com>
Co-authored-by: Mior Muhammad Zaki <crynobone@gmail.com>
Co-authored-by: Mior Muhammad Zaki <crynobone@gmail.com>
antonkomarev
reviewed
Feb 2, 2025
'There is already an app key. Do you want to store the old key before generating a new one?', | ||
true | ||
)) { | ||
$this->call('key:rotate'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer not to have the exact action of the rotate inside method which is named "should*" and returns boolean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Feature:
This PR adds a new
php artisan key:rotate command
and adds a safety level to theKeyGenerateCommand
.When generating a new application key, users are now prompted to optionally save the existing key before overwriting it.
This completes the Laravel 11 rotating
APP_KEY
feature.Example:
When running
php artisan key:generate
, if an existing key is found, the user is prompted:There is already an app key. Do you want to store the old key before generating a new one? (yes/no) [yes]:
If the user confirms, the
key:rotate
command is executed to save the old key before generating a new one.Key Changes:
shouldSaveExistingKey()
method toKeyGenerateCommand
to prompt users to save the existing key.RotateKeyCommand
to handle the key rotation process.Testing - help, please:
I need help with this part. I tested it locally but I don't know how to write a test that alters the .env file
Non-breaking change:
This change is fully backward-compatible and does not have any effect, unless the user opts to save the old key.
Let me know if you’d like to refine this further!
Yes, phpstorm AI plugin, helped me write this PR description ;)