[11.x] Minor Feature a Prohibited If Declined and Prohibited If Accepted validation rules

[osama-98]

Adding a new simple validation rules that are useful for prohibiting attributes if other attribute's value is declined or accepted, in many cases I was setting the exact value to prohibit another attribute and in most cases it has a workaround to achieve the needed validation, please see the below example to understand this change:

Before: for prohibited_if_declined

"free_delivery_fees" => "bail|required",

// this rule only covers the "false" exact value
"delivery_fees" => "prohibited_if:free_delivery_fees,false|numeric|min:1|max:9999",

// this rule only covers the "0" exact value
"delivery_fees" => "prohibited_if:free_delivery_fees,0|numeric|min:1|max:9999",

// And more for all falsy values

After: for prohibited_if_declined

"free_delivery_fees" => "bail|required",
"delivery_fees" => "prohibited_if_declined:free_delivery_fees|numeric|min:1|max:9999",

Before: for prohibited_if_accepted

"discount_disabled" => "bail|required",

// this rule only covers the "true" exact value
"discount" => "prohibited_if:discount_disabled,true|numeric|min:1|max:9999",

// this rule only covers the "1" exact value
"discount" => "prohibited_if:discount_disabled,1|numeric|min:1|max:9999",

// And more for all truthy values

After: for prohibited_if_accepted

"discount_disabled" => "bail|required",
"discount" => "prohibited_if_accepted:discount_disabled|numeric|min:1|max:9999",

[taylorotwell]

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!

[shaedrich]

@osama-98 Maybe, you find laravel-working-group/laravel-form-requests-improved helpful then :)

[osama-98]

@taylorotwell
Thanks for your review and comment, I'll for sure try again with more explaination and test cases 🫡🫡