Support relative paths to SQLite databases #54480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeTowers
commented
Feb 5, 2025
LukeTowers
added a commit
to LukeTowers/framework
that referenced
this pull request
Feb 7, 2025
Applies the suggestion from @Sekaiichi in laravel#54480. realpath() returns false if the file doesn't exist, so the previous code would have been file_exists(false), which technically doesn't match the file_exists signature.
taylorotwell
pushed a commit
that referenced
this pull request
Feb 10, 2025
Applies the suggestion from @Sekaiichi in #54480. realpath() returns false if the file doesn't exist, so the previous code would have been file_exists(false), which technically doesn't match the file_exists signature.
taylorotwell
pushed a commit
to illuminate/database
that referenced
this pull request
Feb 10, 2025
Applies the suggestion from @Sekaiichi in laravel/framework#54480. realpath() returns false if the file doesn't exist, so the previous code would have been file_exists(false), which technically doesn't match the file_exists signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #45626, wintercms/storm#191.
This makes it so that
.envfiles can define the path to the sqlite database file as relative to the project root rather than only supporting absolute paths.