Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to accept correct JSON schema of response from AWS AppConfig #20

Merged
merged 5 commits into from
May 11, 2024

Conversation

lavenderses
Copy link
Owner

What

Bugfix for valid JSON response schema

close #19

How

  • Changed AttributeParser (Parser interface for T-typed feature flag value from AWS AppConfig JSON response) to expect following JSON schema.
    • By change to implement Function, not BiFunction

Previously, BiFunction accepts whole JSON response and following JSON. But actually they were same.
So, simply unified the args to keyNode arg.

{
  // "Add new flag" > "Create flag" > "Off" or "On"
  "enabled": boolean,
  // "Add new flag" > "Create flag" > "Attribute (optional)"
  "flag_value": number | string | boolean | regex,
}

Notes

N/A

@lavenderses lavenderses added the bug Something isn't working label May 11, 2024
@lavenderses lavenderses self-assigned this May 11, 2024
Copy link
Owner Author

@lavenderses lavenderses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lavenderses lavenderses merged commit 08c51d9 into main May 11, 2024
4 checks passed
@lavenderses lavenderses deleted the lavenderses/issue-19 branch May 11, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response format from AWS AppConfig is different
1 participant