Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parser class to parser package #6

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

lavenderses
Copy link
Owner

What

package re-organizing related to parser class

Why

Before refactoring, parser is in app_config_model package, which is the DTO for response from AWS AppConfig.

I think that much more parse function will be added with #5 to AppConfigParser.
So, to clearfy package structure, re-organize it first.

In the next PR, AppConfigParser#attributeAsObject and AppConfigParser#attributeAsBoolean will be moved to outer class.

How

Move AppConfigParser, AppConfigParseException and its test to parser package.

Notes

N/A

@lavenderses lavenderses added the refactor Refactor something, without any spec change label May 6, 2024
@lavenderses lavenderses self-assigned this May 6, 2024
@lavenderses lavenderses changed the title Refactor: Move parser class to parser package Move parser class to parser package May 6, 2024
Copy link
Owner Author

@lavenderses lavenderses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lavenderses lavenderses merged commit b569935 into main May 6, 2024
4 checks passed
@lavenderses lavenderses deleted the lavenderses/issue-5-1 branch May 6, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor something, without any spec change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant