Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README.md typo and response #62

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Fix README.md typo and response #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ directory.
}
```

Disabled feature flag exampel with key name `key_1` and string feature flag value with value `you released`.
Disabled feature flag example with key name `key_1` and string feature flag value with value `you released`.

```json
{
Expand Down Expand Up @@ -200,17 +200,15 @@ curl http://localhost:2772/applications/{application name}/environments/{environ
If you run with the above example, the HTTP request will be like following.

```shell
curl http://localhost:2772/applications/app/environments/env/configurations/profile??flag=key_1
curl http://localhost:2772/applications/app/environments/env/configurations/profile?flag=key_1
```

You will get following JSON response. (This is exactly same as feature flag JSON file.)

```json
{
"key_1": {
"enabled": false,
"flag_value": "you not released"
}
"enabled": false,
"flag_value": "you not released"
}
```

Expand All @@ -233,13 +231,11 @@ If you want to experience dynamic flag value change, let's change the feature fl
After a while, you'll get new feature flag value.

```shell
curl http://localhost:2772/applications/app/environments/env/configurations/profile??flag=key_1
curl http://localhost:2772/applications/app/environments/env/configurations/profile?flag=key_1

{
"key_1": {
"enabled": true,
"flag_value": "you released"
}
"enabled": true,
"flag_value": "you released"
}
```

Expand Down
Loading