Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Kotlin plugin applying from BasePlugin to KotlinPlugin #67

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

lavenderses
Copy link
Owner

What

Re-removal of Kotlin dependencies from :core module.

close #36. relates #61.

How

by oving Kotlin plugin applying from BasePlugin to KotlinPlugin.

I thought this is resoleved in #61, but it remained because kotlin-jvm plugin still had been applied.

Notes

confirmed it.
Screenshot from 2024-06-08 18-52-32

@lavenderses lavenderses added the refactor Refactor something, without any spec change label Jun 8, 2024
@lavenderses lavenderses self-assigned this Jun 8, 2024
Copy link
Owner Author

@lavenderses lavenderses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lavenderses lavenderses merged commit 74b780d into main Jun 8, 2024
4 checks passed
@lavenderses lavenderses deleted the lavenderses/issue-36-2 branch June 8, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor something, without any spec change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Kotlin dependency from :core
1 participant