Share flag_value
JsonNode extraction logic through each extended class
#8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use shared
flag_value
getting method through all extenion parser for each feature flag type.Why
Thanks to #7, parser logic is separeted to each feature flag type.
But, this provider's expected JSON schema from AWS AppConfig is same (following schema, see also
AppConfigValue
).So, the logic which get
flag_value
value asJsonNode
should be same, but now it is separeted.How
Move extraction logic to
AbstractAttributeParser#getValidFlagValueNode
.AbstractAttributeParser
is the abstract implementation for each feature flag type.Extended parser class use this to get
flag_value
value asJsonNode
.Only Object type feature flag does not have expected JsonNode type, so this null check is introduced.
https://github.com/lavenderses/AWSAppConfig-openfeature-provider-java/blob/54c934a29737cfc00fb5be9fa24fcf3ab63715a0/src/main/java/io/github/lavenderses/aws_app_config_openfeature_provider/parser/AbstractAttributeParser.java#L98
Notes
N/A