Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing communitybook image #124

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Conversation

vaibhavpnimkar
Copy link
Contributor

@vaibhavpnimkar vaibhavpnimkar commented Dec 30, 2023

Uploading Screenshot from 2023-12-31 00-19-55.png…
Notes for Reviewers

This PR fixes #120

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Dec 30, 2023

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit c1cb74a
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/659067a8cc437e000847a08c
😎 Deploy Preview https://deploy-preview-124--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vaibhavpnimkar
Copy link
Contributor Author

vaibhavpnimkar commented Dec 30, 2023

its just dco check i forgot to add -"s " while commiting plz ignore that @leecalcote @Yashsharma1911 main issue is resolved

Copy link
Contributor

@iArchitSharma iArchitSharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @vaibhavpnimkar

@saurabh100ni
Copy link
Contributor

Hey @vaibhavpnimkar ,
Thanks for raising the PR, Please add this as your agenda in Doc to discuss it in the Website Meeting tomorrow at 6:30 PM IST.

Subscribe to community calendar for more details of meetings at Layer5.

@leecalcote
Copy link
Member

This looks good to me. In addition to the containment of this image, we need for this page to be rewritten / restyled with flex-based, responsive layout of the cards.

@leecalcote
Copy link
Member

This looks good to me. In addition to the containment of this image, we need for this page to be rewritten / restyled with flex-based, responsive layout of the cards.

A challenge that you might tackle, @vaibhavpnimkar?

@leecalcote leecalcote merged commit 756e34a into layer5io:master Dec 31, 2023
4 checks passed
@Ashparshp
Copy link
Contributor

This looks good to me. In addition to the containment of this image, we need for this page to be rewritten / restyled with flex-based, responsive layout of the cards.

A challenge that you might tackle, @vaibhavpnimkar?

Great job, @vaibhavpnimkar! The fix for the image looks good. Regarding the additional challenge mentioned by @leecalcote about rewriting/restyling the page with a flex-based, responsive layout of the cards, let us know if you plan to tackle that as well.
If you need any assistance or would like help with the additional challenge mentioned by @leecalcote regarding the page rewrite and styling, feel free to let me know. I'm here to help and collaborate!

@vaibhavpnimkar
Copy link
Contributor Author

This looks good to me. In addition to the containment of this image, we need for this page to be rewritten / restyled with flex-based, responsive layout of the cards.

A challenge that you might tackle, @vaibhavpnimkar?

This looks good to me. In addition to the containment of this image, we need for this page to be rewritten / restyled with flex-based, responsive layout of the cards.

A challenge that you might tackle, @vaibhavpnimkar?

ok i would love take this challenge @leecalcote

@vaibhavpnimkar
Copy link
Contributor Author

This looks good to me. In addition to the containment of this image, we need for this page to be rewritten / restyled with flex-based, responsive layout of the cards.

A challenge that you might tackle, @vaibhavpnimkar?

Great job, @vaibhavpnimkar! The fix for the image looks good. Regarding the additional challenge mentioned by @leecalcote about rewriting/restyling the page with a flex-based, responsive layout of the cards, let us know if you plan to tackle that as well. If you need any assistance or would like help with the additional challenge mentioned by @leecalcote regarding the page rewrite and styling, feel free to let me know. I'm here to help and collaborate!

sure will ping you here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Home] Image escaping its container
5 participants