Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kanvas sistent badge to member, and sistent badge to recognition #6211

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Deeptanshu-sankhwar
Copy link

Description

  • Replaces the existing kanvas badge on members.js with the new graphic
  • Adds sistent contributor badge on members.js
  • Adds sistent contributor badge to recognition.js

This PR fixes #6205

Notes for Reviewers
Screenshot 2025-01-29 at 1 02 38 PM
Screenshot 2025-01-29 at 1 10 54 PM

The new graphics look a bit off as compared to others for kanvas and sistent, is this the right behavior, or do the icon-only graphics need to be used for both kanvas and sistent?

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Deeptanshu Sankhwar <deeptanshu@walletsocket.com>
@l5io
Copy link
Contributor

l5io commented Jan 29, 2025

🚀 Preview for commit 5909782 at: https://679a8e2385b64469d00fdff2--layer5.netlify.app

@leecalcote leecalcote requested a review from SAHU-01 January 29, 2025 21:20
@vishalvivekm
Copy link
Contributor

@Deeptanshu-sankhwar
Thank you for your contribution!
Let's discuss this during the website call on Monday at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

@Deeptanshu-sankhwar
Copy link
Author

Hi @vishalvivekm , joining today's call would be a little hard for me. It would be very early morning for me, would you please mention it during the call, I'll go over the youtube recording and make the necessary changes within the PR?
Thanks

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Deeptanshu-sankhwar why png and svg both?

@Deeptanshu-sankhwar
Copy link
Author

Not sure @sudhanshutech . They were just kinda mentioned in the reference(#6205), hence I added both. Is it safe to remove the png if they are not getting used yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add Kanvas and Sistent Contributor badges to members and recognition pages
4 participants