Fix text and image overlap in careers page #6226
Open
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
M-DEV-1
changed the title
|
🚀 Preview for commit f006aac at: https://67a5570f84dbccc837497cb9--layer5.netlify.app |
vishalvivekm
reviewed
Feb 8, 2025
| @@ -9,6 +9,7 @@ const PageHeaderWrapper = styled.div` | |||
| text-align: center; | |||
| position: relative; | |||
| height: auto; | |||
| margin-top: 3rem; | |||
There was a problem hiding this comment.
@M-DEV-1 this is reused in multiple sections of the site and we need to be cautious that it doesn’t alter their styles.
for example community-members page, the margin-top hasn't increased too much, but ideally, we would want to avoid it.
vishalvivekm
requested changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the text overlap issue in the Open Source Internship section by increasing the margin below the image and adjusting
PageHeaderspacing to ensure proper separation.This PR fixes #6225
Before:
After:
Notes for Reviewers
Signed commits