Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows-pyscf-fix #81

Merged
merged 2 commits into from
Jan 15, 2025
Merged

workflows-pyscf-fix #81

merged 2 commits into from
Jan 15, 2025

Conversation

YAY-C
Copy link
Contributor

@YAY-C YAY-C commented Jan 15, 2025

  • switched env specs to minimal
  • try installing pyscf through conda (only for linux-based envs)

@YAY-C YAY-C changed the title workflows and envs workflows-pyscf-fix Jan 15, 2025
@YAY-C YAY-C marked this pull request as ready for review January 15, 2025 10:36
@YAY-C YAY-C requested a review from briling January 15, 2025 10:37
@YAY-C
Copy link
Contributor Author

YAY-C commented Jan 15, 2025

@briling
Installing pyscf using conda channels solves the problem!
unfortunately it's not platform portable (at least for MacOS, cause the channel is somewhat broken)

@briling
Copy link
Contributor

briling commented Jan 15, 2025

@YAY-C
the github action is linux only no?
i thought we have different installation mechanisms for github autotests and for pip install

@YAY-C
Copy link
Contributor Author

YAY-C commented Jan 15, 2025

Yes we do have different mechanism!
But before you also could install the environment from the yml file both on linux and MacOS, and the env would have qstack nicely installed in it. But installing pyscf with conda does not work on Mac.

  • maybe put a comment in the README.md

@briling briling merged commit d2bced0 into master Jan 15, 2025
2 checks passed
@briling
Copy link
Contributor

briling commented Jan 15, 2025

can we have linux and mac env files then?

@YAY-C YAY-C linked an issue Jan 15, 2025 that may be closed by this pull request
This was referenced Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workflows broken
2 participants