Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect errors/tracebacks to the right logging stream #114

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Conversation

gipert
Copy link
Member

@gipert gipert commented Mar 12, 2025

Closes #107.

@ggmarshall seems to work, try switching between console/dataflow handlers in the logging config. You can merge if it works.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 42.70%. Comparing base (c7a281b) to head (767bd49).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
workflow/src/legenddataflow/log.py 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   43.54%   42.70%   -0.85%     
==========================================
  Files          18       18              
  Lines        1162     1185      +23     
==========================================
  Hits          506      506              
- Misses        656      679      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ggmarshall ggmarshall merged commit b15a0b3 into main Mar 13, 2025
11 checks passed
@ggmarshall ggmarshall deleted the log branch March 13, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix logging
2 participants