Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spm speedup #117

Merged
merged 4 commits into from
Mar 13, 2025
Merged

Spm speedup #117

merged 4 commits into from
Mar 13, 2025

Conversation

ggmarshall
Copy link
Collaborator

@ggmarshall ggmarshall commented Mar 13, 2025

@gipert
Pre-compiling the det status and channelmap catalogs gives a huge speedup

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 43.02%. Comparing base (9a6f955) to head (3e5f23d).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
workflow/src/legenddataflow/pre_compile_catalog.py 0.00% 17 Missing ⚠️
workflow/src/legenddataflow/pars_loading.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   43.64%   43.02%   -0.62%     
==========================================
  Files          18       19       +1     
  Lines        1164     1183      +19     
==========================================
+ Hits          508      509       +1     
- Misses        656      674      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gipert
Copy link
Member

gipert commented Mar 13, 2025

supa dupa fast

@gipert
Copy link
Member

gipert commented Mar 13, 2025

seems to work thanks a lot giorgio

@gipert gipert merged commit 1528085 into main Mar 13, 2025
11 checks passed
@gipert gipert deleted the spm_speedup branch March 13, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants