Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first version of CITATION.cff #64

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Add first version of CITATION.cff #64

merged 3 commits into from
Jan 30, 2024

Conversation

gipert
Copy link
Member

@gipert gipert commented Jan 25, 2024

@jasondet @iguinn please check your info. @MoritzNeuberger @gracesong312 @SamuelBorden please let me have your ORCID.

I used this page: https://github.com/legend-exp/legend-pydataobj/graphs/contributors to determine the author list and I did not include contributors of bug fixes or other minor things.

Let me know what do you think about this selection.

@gipert gipert added the documentation Improvements or additions to documentation label Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae371f2) 72.91% compared to head (2f53d3c) 72.91%.

❗ Current head 2f53d3c differs from pull request most recent head 63a8305. Consider uploading reports for the commit 63a8305 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   72.91%   72.91%           
=======================================
  Files          29       29           
  Lines        2466     2466           
=======================================
  Hits         1798     1798           
  Misses        668      668           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jasondet
Copy link
Contributor

looks good for me! Thanks Luigi!

@gipert gipert marked this pull request as ready for review January 30, 2024 10:00
@gipert gipert merged commit 3a08280 into main Jan 30, 2024
11 of 12 checks passed
@gipert gipert deleted the cit branch January 30, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants