Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcm handle multiple cols, change to vov #599

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

ggmarshall
Copy link
Collaborator

@ggmarshall ggmarshall commented Mar 11, 2025

  • update pargen
  • update evt
  • update testdata
  • moar tests

needs: legend-exp/legend-testdata#26

SiPM changes need testing, maybe add unit tests?

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 86.54709% with 30 lines in your changes missing coverage. Please review.

Project coverage is 49.37%. Comparing base (e84c132) to head (cbc66c5).

Files with missing lines Patch % Lines
src/pygama/evt/modules/spms.py 0.00% 7 Missing ⚠️
src/pygama/evt/modules/xtalk.py 56.25% 7 Missing ⚠️
src/pygama/pargen/data_cleaning.py 16.66% 5 Missing ⚠️
src/pygama/evt/tcm.py 94.02% 4 Missing ⚠️
src/pygama/pargen/dsp_optimize.py 0.00% 3 Missing ⚠️
src/pygama/evt/aggregators.py 96.15% 2 Missing ⚠️
src/pygama/evt/build_tcm.py 96.55% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
+ Coverage   48.63%   49.37%   +0.73%     
==========================================
  Files          60       60              
  Lines        7947     8047     +100     
==========================================
+ Hits         3865     3973     +108     
+ Misses       4082     4074       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ggmarshall ggmarshall marked this pull request as draft March 11, 2025 04:36
@ggmarshall
Copy link
Collaborator Author

@tdixon97 I've updated evt to be similar to reboost if you can take a look

@ggmarshall ggmarshall marked this pull request as ready for review March 12, 2025 23:39
@ggmarshall ggmarshall marked this pull request as draft March 13, 2025 05:17
@ggmarshall ggmarshall marked this pull request as ready for review March 13, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant