-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display each font text with the corresponding font in theme settings #1023
feat: display each font text with the corresponding font in theme settings #1023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR, I like the final result a lot.
However, it results in users having to load all of these fonts, which is very wasteful if you're just using the default one.
The Google fonts API seems to have an option to only request a subset of characters, which would help with this: https://developers.google.com/fonts/docs/getting_started#optimizing_your_font_requests
I don't think there is a solution for the open-dyslexic font however, which is a problem, but I could investigate.
Let me know if you need help with this (either by here or just DM me on Discord/somewhere else).
I have made a few changes to your PR:
|
I am submitting a pull request where I have made changes to the source code to enhance the font selection dropdown menu on the website.
Now, each font name in the dropdown is displayed in its corresponding font style.
This update makes the font selection process more intuitive and user-friendly, as users can see a preview of each font without having to test them one by one.
Old Appearance:
New Appearance: