Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/codescene-refactor #38

Merged
merged 13 commits into from
Dec 2, 2024
Merged

feature/codescene-refactor #38

merged 13 commits into from
Dec 2, 2024

Conversation

lekman
Copy link
Owner

@lekman lekman commented Dec 2, 2024

Why is the change needed?

Adding refactoring from CodeScene static analysis, to improve readability and reduce complexity of argument parsing to target files.

What was changed?

Features:

  • Implement PreviewProcessArguments class for argument handling and parsing
  • Add pull request template and update .gitignore for temporary files

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 76.78571% with 13 lines in your changes missing coverage. Please review.

Project coverage is 81.59%. Comparing base (9b83c14) to head (053804e).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
AzureLiquid.Preview/PreviewProcess.cs 62.50% 8 Missing and 4 partials ⚠️
AzureLiquid.Preview/PreviewProcessArguments.cs 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   73.95%   81.59%   +7.63%     
==========================================
  Files           2        3       +1     
  Lines         192      163      -29     
  Branches       17       19       +2     
==========================================
- Hits          142      133       -9     
+ Misses         46       23      -23     
- Partials        4        7       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AzureLiquid.Preview/PreviewProcess.cs Fixed Show fixed Hide fixed
AzureLiquid.Preview/PreviewProcess.cs Dismissed Show dismissed Hide dismissed
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Qodana for .NET

3 new problems were found

Inspection name Severity Problems
Expression is always 'true' or 'false' according to nullable reference types' annotations 🔶 Warning 1
Conditional access qualifier expression is not null according to nullable reference types' annotations 🔶 Warning 1
Use 'Array.Empty<T>()' ◽️ Notice 1

☁️ View the detailed Qodana report

Detected 23 dependencies

Third-party software list

This page lists the third-party software dependencies used in AzureLiquid

Dependency Version Licenses
AzureLiquid 1.1.1 Apache-2.0
DotLiquid-Net6 1.0.14 Apache-2.0
DotLiquid-Net6 1.0.15 Apache-2.0
Microsoft.CodeAnalysis.Analyzers 3.3.3 MIT
Microsoft.CodeAnalysis.Analyzers 3.3.4 MIT
Microsoft.CodeAnalysis.Common 4.4.0 MIT
Microsoft.CodeAnalysis.Common 4.7.0 MIT
Newtonsoft.Json 13.0.1 MIT
Newtonsoft.Json 13.0.3 MIT
Roslynator.Analyzers 4.12.9 Apache-2.0
Roslynator.Analyzers 4.4.0 Apache-2.0
Roslynator.Core 4.12.9 Apache-2.0
Roslynator.Core 4.4.0 Apache-2.0
SonarAnalyzer.CSharp 10.3.0.106239 EPL-2.0
StyleCop.Analyzers 1.1.118 MIT
System.Collections.Immutable 6.0.0 MIT
System.Collections.Immutable 7.0.0 MIT
System.Memory 4.5.5 MIT
System.Reflection.Metadata 5.0.0 MIT
System.Reflection.Metadata 7.0.0 MIT
System.Runtime.CompilerServices.Unsafe 6.0.0 MIT
System.Text.Encoding.CodePages 6.0.0 MIT
System.Threading.Tasks.Extensions 4.5.4 MIT
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Make GetArgumentIndex and IsArgMatch methods internal and add unit tests for argument processing
AzureLiquid.Preview/PreviewProcess.cs Dismissed Show dismissed Hide dismissed
@lekman lekman merged commit e332579 into main Dec 2, 2024
17 checks passed
@lekman lekman deleted the feature/codescene-refactor branch December 2, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant