tools/collect-sources.sh: Remove unknown keyword warnings for GNU tar #4687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rootfs tarball includes extended PAX headers, which GNU tar does not support. This commit applies to collect-sources.sh script the same check found in Makefile (for TAR_OPTS), removing "unknown keyword" warnings when using GNU tar (non BSD). Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
deitch
approved these changes
Mar 17, 2025
|
Eden tests are not applicable in this case because just the tools/collect-sources.sh it's changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing PR #4686 I realized we still have "unknown keyword" warnings when using GNU tar for the
collect-sources.shscript:https://github.com/lf-edge/eve/actions/runs/13900623160/job/38905628030#step:4:144
This PR applies the same check found in Makefile also for the
collect-sources.shscript, so we can get rid of these warnings that throws a lot of data to output, which is annoying specially when checking our GH actions output....