Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Update E2E test workflow to handle multiple app deployments #691

Closed
wants to merge 12 commits into from

Conversation

FunamaYukina
Copy link
Member

@FunamaYukina FunamaYukina commented Feb 6, 2025

Summary

I added a GitHub Action for e2e test, but it was running only on erd-web and not on cli, so I fixed it.

One mistake in the test has also been fixed.

Related Issue

Testing

Other Information

@FunamaYukina FunamaYukina self-assigned this Feb 6, 2025
Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: 8ab3c61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@FunamaYukina FunamaYukina mentioned this pull request Feb 6, 2025
@FunamaYukina FunamaYukina force-pushed the running-the-e2e-github-action-correctly branch from 38c0fc5 to b95a929 Compare February 6, 2025 08:45
@FunamaYukina FunamaYukina force-pushed the running-the-e2e-github-action-correctly branch from a67c775 to c08381c Compare February 6, 2025 09:01
@FunamaYukina FunamaYukina force-pushed the running-the-e2e-github-action-correctly branch from c08381c to 7043e62 Compare February 6, 2025 09:10
@FunamaYukina FunamaYukina force-pushed the running-the-e2e-github-action-correctly branch from 7043e62 to 3bd48b0 Compare February 6, 2025 13:03
@FunamaYukina FunamaYukina had a problem deploying to preview - @liam-hq/erd-sample February 6, 2025 13:03 — with GitHub Actions Failure
Copy link
Contributor

qodo-merge-pro-for-open-source bot commented Feb 6, 2025

CI Feedback 🧐

(Feedback updated until commit 8ab3c61)

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: Deploy (erd-web, VERCEL_PROJECT_ID_ERD_WEB)

Failed stage: Deploy Application [❌]

Failure summary:

The action failed because Vercel's build process couldn't find the "public" output directory after
the build completed. This is a configuration issue where:

  • The build process completed successfully (10/10 tasks completed)
  • But the expected "public" directory for static assets was not found
  • This directory needs to be configured in the Project Settings or generated during build

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    243:  Scope: all 11 workspace projects
    244:  Lockfile is up to date, resolution step is skipped
    245:  Progress: resolved 1, reused 0, downloaded 0, added 0
    246:  Packages: +1440
    247:  ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
    248:  Progress: resolved 1440, reused 1273, downloaded 0, added 0
    249:  Progress: resolved 1440, reused 1420, downloaded 0, added 508
    250:  Progress: resolved 1440, reused 1420, downloaded 0, added 1440, done
    251:  WARN  Failed to create bin at /home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/.bin/liam. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/frontend/packages/cli/dist-cli/bin/cli.js'
    ...
    
    256:  + @turbo/gen 2.1.2
    257:  + syncpack 13.0.0
    258:  + turbo 2.1.2
    259:  frontend/apps/docs postinstall$ fumadocs-mdx
    260:  frontend/apps/docs postinstall: [MDX] types generated
    261:  frontend/apps/docs postinstall: Done
    262:  frontend/apps/erd-web postinstall$ cp ../../packages/db-structure/node_modules/@ruby/prism/src/prism.wasm prism.wasm
    263:  frontend/apps/erd-web postinstall: Done
    264:  WARN  Failed to create bin at /home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/.bin/liam. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/@liam-hq/cli/dist-cli/bin/cli.js'
    ...
    
    325:  sentry.client.config.ts
    326:  sentry.edge.config.ts
    327:  sentry.server.config.ts
    328:  source.config.ts
    329:  tailwind.config.js
    330:  tsconfig.json
    331:  ./frontend/apps/docs/app:
    332:  docs
    333:  global-error.tsx
    ...
    
    515:  scripts
    516:  sentry.client.config.ts
    517:  sentry.edge.config.ts
    518:  sentry.server.config.ts
    519:  tsconfig.json
    520:  ./frontend/apps/erd-web/app:
    521:  erd
    522:  favicon.ico
    523:  global-error.tsx
    ...
    
    664:  cli
    665:  globals.css
    666:  index.ts
    667:  main.tsx
    668:  vite-env.d.ts
    669:  ./frontend/packages/cli/src/cli:
    670:  actionRunner.ts
    671:  erdCommand
    672:  errors.ts
    ...
    
    743:  ./frontend/packages/db-structure/src:
    744:  index.ts
    745:  parser
    746:  parser.ts
    747:  schema
    748:  ./frontend/packages/db-structure/src/parser:
    749:  __snapshots__
    750:  __tests__
    751:  errors.ts
    ...
    
    900:  ERDRenderer
    901:  index.ts
    902:  ./frontend/packages/erd-core/src/components/ERDRenderer:
    903:  AppBar
    904:  CardinalityMarkers
    905:  ERDContent
    906:  ERDRenderer.module.css
    907:  ERDRenderer.tsx
    908:  ErrorDisplay
    ...
    
    1046:  TableHeader.tsx
    1047:  index.ts
    1048:  ./frontend/packages/erd-core/src/components/ERDRenderer/ERDContent/useAutoLayout:
    1049:  convertElkNodesToNodes.ts
    1050:  convertNodesToElkNodes.ts
    1051:  getElkLayout.ts
    1052:  index.ts
    1053:  useAutoLayout.ts
    1054:  ./frontend/packages/erd-core/src/components/ERDRenderer/ErrorDisplay:
    1055:  ErrorDisplay.module.css
    1056:  ErrorDisplay.tsx
    1057:  MrJack.tsx
    1058:  NetworkErrorDisplay.module.css
    1059:  NetworkErrorDisplay.tsx
    1060:  ParseErrorDisplay.module.css
    1061:  ParseErrorDisplay.tsx
    ...
    
    1510:  > pnpm run '/^gen:.*/'
    1511:  > @liam-hq/erd-core@0.0.25 gen:css /home/runner/work/liam/liam/frontend/packages/erd-core
    1512:  > tcm src
    1513:  Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/styles/variables.css.d.ts
    1514:  Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/styles/globals.css.d.ts
    1515:  Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/components/ERDRenderer/ERDRenderer.module.css.d.ts
    1516:  Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/components/ERDRenderer/TableDetailDrawer/TableDetailDrawer.module.css.d.ts
    1517:  Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/components/ERDRenderer/RelationshipEdgeParticleMarker/RelationshipEdgeParticleMarker.module.css.d.ts
    1518:  Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/components/ERDRenderer/ErrorDisplay/ParseErrorDisplay.module.css.d.ts
    1519:  Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/components/ERDRenderer/ErrorDisplay/NetworkErrorDisplay.module.css.d.ts
    1520:  Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/components/ERDRenderer/ErrorDisplay/ErrorDisplay.module.css.d.ts
    ...
    
    1594:  . build:vite:  * [new branch]        add_e2e_test_on_toolbar  -> origin/add_e2e_test_on_toolbar
    1595:  . build:vite:  * [new branch]        avoid-semicolon-logic    -> origin/avoid-semicolon-logic
    1596:  . build:vite:  * [new branch]        avoid-semicolon-logic-2  -> origin/avoid-semicolon-logic-2
    1597:  . build:vite:  * [new branch]        changeset-invest1        -> origin/changeset-invest1
    1598:  . build:vite:  * [new branch]        changeset-invest3        -> origin/changeset-invest3
    1599:  . build:vite:  * [new branch]        changeset-release/changeset-invest1 -> origin/changeset-release/changeset-invest1
    1600:  . build:vite:  * [new branch]        check-github-action      -> origin/check-github-action
    1601:  . build:vite:  * [new branch]        cli-schema-json-for-local -> origin/cli-schema-json-for-local
    1602:  . build:vite:  * [new branch]        console-error-1-draft    -> origin/console-error-1-draft
    1603:  . build:vite:  * [new branch]        debug-cli-versin         -> origin/debug-cli-versin
    1604:  . build:vite:  * [new branch]        debug-mh4gf              -> origin/debug-mh4gf
    1605:  . build:vite:  * [new branch]        devin/1738820244-add-init-command-tests -> origin/devin/1738820244-add-init-command-tests
    1606:  . build:vite:  * [new branch]        devin/1738828298-add-multiline-comment-support -> origin/devin/1738828298-add-multiline-comment-support
    1607:  . build:vite:  * [new branch]        devin/1739162278-add-mssql-support -> origin/devin/1739162278-add-mssql-support
    1608:  . build:vite:  * [new branch]        enhance-the-highlighting-of-related-table-nodes-when-hovering-usememo-1 -> origin/enhance-the-highlighting-of-related-table-nodes-when-hovering-usememo-1
    1609:  . build:vite:  * [new branch]        error-message-erd-network-error -> origin/error-message-erd-network-error
    ...
    
    1636:  . build:vite:  * [new branch]        poc/stroke-dasharray     -> origin/poc/stroke-dasharray
    1637:  . build:vite:  * [new branch]        primary-key-icon-2       -> origin/primary-key-icon-2
    1638:  . build:vite:  * [new branch]        reduce-set-node-calling-chance-3 -> origin/reduce-set-node-calling-chance-3
    1639:  . build:vite:  * [new branch]        refactor-active-highlight -> origin/refactor-active-highlight
    1640:  . build:vite:  * [new branch]        refactor-to-testcases    -> origin/refactor-to-testcases
    1641:  . build:vite:  * [new branch]        refactor_edge_cardinality_by_using_custom_mark -> origin/refactor_edge_cardinality_by_using_custom_mark
    1642:  . build:vite:  * [new branch]        refactor_hidden_node_handle -> origin/refactor_hidden_node_handle
    1643:  . build:vite:  * [new branch]        release-debug-branch     -> origin/release-debug-branch
    1644:  . build:vite:  * [new branch]        revert-435-error-message-erd -> origin/revert-435-error-message-erd
    ...
    
    1756:  ../../../node_modules/.pnpm/require-in-the-middle@7.5.0/node_modules/require-in-the-middle/index.js
    1757:  ../../../node_modules/.pnpm/@opentelemetry+instrumentation@0.56.0_@opentelemetry+api@1.9.0/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js
    1758:  ../../../node_modules/.pnpm/@opentelemetry+instrumentation@0.56.0_@opentelemetry+api@1.9.0/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/index.js
    1759:  ../../../node_modules/.pnpm/@opentelemetry+instrumentation@0.56.0_@opentelemetry+api@1.9.0/node_modules/@opentelemetry/instrumentation/build/esm/platform/index.js
    1760:  ../../../node_modules/.pnpm/@opentelemetry+instrumentation@0.56.0_@opentelemetry+api@1.9.0/node_modules/@opentelemetry/instrumentation/build/esm/index.js
    1761:  ../../../node_modules/.pnpm/@sentry+opentelemetry@8.49.0_@opentelemetry+api@1.9.0_@opentelemetry+core@1.30.1_@opentelemet_fiv5wn62ct5asz6dpywkzviqyq/node_modules/@sentry/opentelemetry/build/cjs/index.js
    1762:  ../../../node_modules/.pnpm/@sentry+nextjs@8.49.0_@opentelemetry+core@1.30.1_@opentelemetry+api@1.9.0__@opentelemetry+ins_fwimtgpgjfk3j2xbgl5p655t5q/node_modules/@sentry/nextjs/build/cjs/server/index.js
    1763:  ../../../node_modules/.pnpm/@sentry+nextjs@8.49.0_@opentelemetry+core@1.30.1_@opentelemetry+api@1.9.0__@opentelemetry+ins_fwimtgpgjfk3j2xbgl5p655t5q/node_modules/@sentry/nextjs/build/cjs/index.server.js
    1764:  ./app/global-error.tsx
    ...
    
    1858:  ../../../node_modules/.pnpm/require-in-the-middle@7.5.0/node_modules/require-in-the-middle/index.js
    1859:  ../../../node_modules/.pnpm/@opentelemetry+instrumentation@0.56.0_@opentelemetry+api@1.9.0/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js
    1860:  ../../../node_modules/.pnpm/@opentelemetry+instrumentation@0.56.0_@opentelemetry+api@1.9.0/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/index.js
    1861:  ../../../node_modules/.pnpm/@opentelemetry+instrumentation@0.56.0_@opentelemetry+api@1.9.0/node_modules/@opentelemetry/instrumentation/build/esm/platform/index.js
    1862:  ../../../node_modules/.pnpm/@opentelemetry+instrumentation@0.56.0_@opentelemetry+api@1.9.0/node_modules/@opentelemetry/instrumentation/build/esm/index.js
    1863:  ../../../node_modules/.pnpm/@sentry+opentelemetry@8.49.0_@opentelemetry+api@1.9.0_@opentelemetry+core@1.30.1_@opentelemet_fiv5wn62ct5asz6dpywkzviqyq/node_modules/@sentry/opentelemetry/build/cjs/index.js
    1864:  ../../../node_modules/.pnpm/@sentry+nextjs@8.49.0_@opentelemetry+core@1.30.1_@opentelemetry+api@1.9.0__@opentelemetry+ins_fwimtgpgjfk3j2xbgl5p655t5q/node_modules/@sentry/nextjs/build/cjs/server/index.js
    1865:  ../../../node_modules/.pnpm/@sentry+nextjs@8.49.0_@opentelemetry+core@1.30.1_@opentelemetry+api@1.9.0__@opentelemetry+ins_fwimtgpgjfk3j2xbgl5p655t5q/node_modules/@sentry/nextjs/build/cjs/index.server.js
    1866:  ./app/global-error.tsx
    ...
    
    1998:  > @liam-hq/erd-core@0.0.25 gen:css /home/runner/work/liam/liam/frontend/packages/erd-core
    1999:  > tcm src
    2000:  Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/styles/variables.css.d.ts
    2001:  Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/styles/globals.css.d.ts
    2002:  Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/components/ERDRenderer/ERDRenderer.module.css.d.ts
    2003:  Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/components/ERDRenderer/Toolbar/DesktopToolbar.module.css.d.ts
    2004:  Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/components/ERDRenderer/TableDetailDrawer/TableDetailDrawer.module.css.d.ts
    2005:  Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/components/ERDRenderer/RelationshipEdgeParticleMarker/RelationshipEdgeParticleMarker.module.css.d.ts
    2006:  Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/components/ERDRenderer/ErrorDisplay/ParseErrorDisplay.module.css.d.ts
    2007:  Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/components/ERDRenderer/ErrorDisplay/NetworkErrorDisplay.module.css.d.ts
    2008:  Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/components/ERDRenderer/ErrorDisplay/ErrorDisplay.module.css.d.ts
    ...
    
    2133:  ../../../node_modules/.pnpm/require-in-the-middle@7.5.0/node_modules/require-in-the-middle/index.js
    2134:  ../../../node_modules/.pnpm/@opentelemetry+instrumentation@0.56.0_@opentelemetry+api@1.9.0/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js
    2135:  ../../../node_modules/.pnpm/@opentelemetry+instrumentation@0.56.0_@opentelemetry+api@1.9.0/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/index.js
    2136:  ../../../node_modules/.pnpm/@opentelemetry+instrumentation@0.56.0_@opentelemetry+api@1.9.0/node_modules/@opentelemetry/instrumentation/build/esm/platform/index.js
    2137:  ../../../node_modules/.pnpm/@opentelemetry+instrumentation@0.56.0_@opentelemetry+api@1.9.0/node_modules/@opentelemetry/instrumentation/build/esm/index.js
    2138:  ../../../node_modules/.pnpm/@sentry+opentelemetry@8.49.0_@opentelemetry+api@1.9.0_@opentelemetry+core@1.30.1_@opentelemet_fiv5wn62ct5asz6dpywkzviqyq/node_modules/@sentry/opentelemetry/build/cjs/index.js
    2139:  ../../../node_modules/.pnpm/@sentry+nextjs@8.49.0_@opentelemetry+core@1.30.1_@opentelemetry+api@1.9.0__@opentelemetry+ins_fwimtgpgjfk3j2xbgl5p655t5q/node_modules/@sentry/nextjs/build/cjs/server/index.js
    2140:  ../../../node_modules/.pnpm/@sentry+nextjs@8.49.0_@opentelemetry+core@1.30.1_@opentelemetry+api@1.9.0__@opentelemetry+ins_fwimtgpgjfk3j2xbgl5p655t5q/node_modules/@sentry/nextjs/build/cjs/index.server.js
    2141:  ./app/global-error.tsx
    ...
    
    2228:  ../../../node_modules/.pnpm/require-in-the-middle@7.5.0/node_modules/require-in-the-middle/index.js
    2229:  ../../../node_modules/.pnpm/@opentelemetry+instrumentation@0.56.0_@opentelemetry+api@1.9.0/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js
    2230:  ../../../node_modules/.pnpm/@opentelemetry+instrumentation@0.56.0_@opentelemetry+api@1.9.0/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/index.js
    2231:  ../../../node_modules/.pnpm/@opentelemetry+instrumentation@0.56.0_@opentelemetry+api@1.9.0/node_modules/@opentelemetry/instrumentation/build/esm/platform/index.js
    2232:  ../../../node_modules/.pnpm/@opentelemetry+instrumentation@0.56.0_@opentelemetry+api@1.9.0/node_modules/@opentelemetry/instrumentation/build/esm/index.js
    2233:  ../../../node_modules/.pnpm/@sentry+node@8.49.0/node_modules/@sentry/node/build/cjs/integrations/node-fetch.js
    2234:  ../../../node_modules/.pnpm/@sentry+node@8.49.0/node_modules/@sentry/node/build/cjs/index.js
    2235:  ../../../node_modules/.pnpm/@sentry+nextjs@8.49.0_@opentelemetry+core@1.30.1_@opentelemetry+api@1.9.0__@opentelemetry+ins_fwimtgpgjfk3j2xbgl5p655t5q/node_modules/@sentry/nextjs/build/cjs/index.server.js
    2236:  ./app/global-error.tsx
    ...
    
    2281:  └ other shared chunks (total)          2.52 kB
    2282:  ○  (Static)   prerendered as static content
    2283:  ƒ  (Dynamic)  server-rendered on demand
    2284:  ##[endgroup]
    2285:  Tasks:    10 successful, 10 total
    2286:  Cached:    0 cached, 10 total
    2287:  Time:    1m36.389s 
    2288:  Summary:    /home/runner/work/liam/liam/.turbo/runs/2spwi7JzfmsOHnB6fCM8dXpNQ4y.json
    2289:  Error: No Output Directory named "public" found after the Build completed. You can configure the Output Directory in your Project Settings.
    2290:  Learn More: https://vercel.link/missing-public-directory
    2291:  ##[error]Process completed with exit code 1.
    

    Copy link
    Contributor

    CI Feedback 🧐

    A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

    Action: Deploy (@liam-hq/erd-sample, VERCEL_PROJECT_ID_ERD_SAMPLE)

    Failed stage: Set up job [❌]

    Failed test name: ""

    Failure summary:

    The action failed because it's using a deprecated version of the actions/upload-artifact action
    (v3). GitHub has announced the deprecation of this version, and the workflow needs to be updated to
    use a newer version of the action.

    Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    16:  Contents: read
    17:  Deployments: write
    18:  Metadata: read
    19:  ##[endgroup]
    20:  Secret source: Actions
    21:  Prepare workflow directory
    22:  Prepare all required actions
    23:  Getting action download info
    24:  ##[error]This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v3`. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
    

    @FunamaYukina FunamaYukina force-pushed the running-the-e2e-github-action-correctly branch from 3bd48b0 to 2b96240 Compare February 6, 2025 13:05
    @FunamaYukina FunamaYukina temporarily deployed to preview - @liam-hq/erd-sample February 6, 2025 13:06 — with GitHub Actions Inactive
    @FunamaYukina FunamaYukina force-pushed the running-the-e2e-github-action-correctly branch from 2b96240 to b829c69 Compare February 7, 2025 00:24
    @FunamaYukina FunamaYukina had a problem deploying to preview - @liam-hq/erd-sample February 7, 2025 00:24 — with GitHub Actions Failure
    @FunamaYukina FunamaYukina force-pushed the running-the-e2e-github-action-correctly branch from d820890 to dd3f629 Compare February 10, 2025 04:43
    @FunamaYukina FunamaYukina force-pushed the running-the-e2e-github-action-correctly branch from dd3f629 to f75e772 Compare February 10, 2025 04:48
    @FunamaYukina
    Copy link
    Member Author

    I will try for another PR!🙏

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant