Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use safe parsing function for test fixtures #2344

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Use safe parsing function for test fixtures #2344

merged 1 commit into from
Apr 18, 2024

Conversation

Changaco
Copy link
Member

@Changaco Changaco commented Apr 18, 2024

Resolves https://hackerone.com/reports/2467232. The unsafe parsing function is only called on files checked into the repository, so it isn't exactly fed untrusted data. However, I'm willing to consider this a valid vulnerability in light of the recent xz backdoor incident, because the files in question are big and generated automatically, so an attacker might have been able to sneak an exploit in there without me noticing.

Sadly there are other attack vectors, and mitigating them will require significantly more work. PyPI, the software distribution service used by Liberapay to download its dependencies, is unsafe in its design. Any malicious entity who gains the ability to upload packages to PyPI for one of Liberapay's dependencies would have a good chance of breaching Liberapay completely. Related issue: #1305.

@Changaco Changaco added the defense protecting ourselves, our users and innocent third-parties label Apr 18, 2024
@Changaco Changaco merged commit 5bc6de8 into master Apr 18, 2024
2 checks passed
@Changaco Changaco deleted the safe-yaml branch April 18, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defense protecting ourselves, our users and innocent third-parties
Development

Successfully merging this pull request may close these issues.

1 participant