Use safe parsing function for test fixtures #2344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://hackerone.com/reports/2467232. The unsafe parsing function is only called on files checked into the repository, so it isn't exactly fed untrusted data. However, I'm willing to consider this a valid vulnerability in light of the recent xz backdoor incident, because the files in question are big and generated automatically, so an attacker might have been able to sneak an exploit in there without me noticing.
Sadly there are other attack vectors, and mitigating them will require significantly more work. PyPI, the software distribution service used by Liberapay to download its dependencies, is unsafe in its design. Any malicious entity who gains the ability to upload packages to PyPI for one of Liberapay's dependencies would have a good chance of breaching Liberapay completely. Related issue: #1305.