Unify and improve the client-side logic for form submissions #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changaco
force-pushed
the
js-submit
branch
2 times, most recently
from
64abb62 to
71d06cd
Compare
- drop the `js-submit` class and merge the two separate `submit` event handlers into one
- it's now easy to run custom functions both before and after a form submission
- however, the after functions may not be called if the server responds to the form submission with an error
- the unified function's source code is commented
- the unified function sends debugging messages to the console
- form inputs are no longer disabled during submission, because it was complicating the JavaScript code
- CSS is used instead to gray out the entire form and disable mouse events, but keyboard events aren't be disabled
- the submission feedback overlay is back, for forms making slow requests before submitting
- replace most uses of `jQuery.ajax()` with `fetch()`, simplifying the `Liberapay.error()` function and removing the need for the `Liberapay.getCookie()` function
- all forms are now required to include an anti-CSRF token, whereas previously the forms that required JavaScript didn't need to contain the token as it would be taken from the cookies anyway
- since we no longer need the `csrf_token` cookie to be accessible from JavaScript, mark it as `httponly`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the description of the last commit.