PWX-34256_op-23.10.2: node-wiper fix for custom-dir installs (#1388) #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zoran Rajic <zox@portworx.com> Manually fixed Conflicts: drivers/storage/portworx/util/util.go
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## px-rel-23.10.2 #1389 +/- ##
===============================================
Coverage 79.73% 79.74%
===============================================
Files 60 60
Lines 17349 17372 +23
===============================================
+ Hits 13834 13853 +19
- Misses 2543 2545 +2
- Partials 972 974 +2 ☔ View full report in Codecov by Sentry. |
|
merging this cherry-pick PR without the explicit review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zoran Rajic zox@portworx.com
Manually fixed Conflicts:
drivers/storage/portworx/util/util.go
What this PR does / why we need it:
This is a cherry-pick of #1388 into
px-rel-23.10.2branchWhich issue(s) this PR fixes (optional)
Closes # PWX-34256 (op-23.10.2)
Special notes for your reviewer: