Update plugin deployment PullPolicy to Always regardless of STC's PullPolicy #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1422 +/- ##
=======================================
Coverage 75.84% 75.84%
=======================================
Files 66 66
Lines 18988 18989 +1
=======================================
+ Hits 14402 14403 +1
Misses 3560 3560
Partials 1026 1026 ☔ View full report in Codecov by Sentry. |
nikita-bhatia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Update imagePullPolicy for px-plugin pods to always, regardless of STC's ImagePullPolicy, to fetch latest security/other fixes on existing tag.
The imagePullPolicy for the pod is now being set to Always, after StorageClusterSetting is applied, so that STC's PullPolicy doesn't override.
Special notes for your reviewer:
Verified that ImagePullPolicy of plugin pod is set to 'Always' if