Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-36817/PWX-32899_pt1: K8s DNS domain fix #1437

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

zoxpx
Copy link
Collaborator

@zoxpx zoxpx commented Feb 9, 2024

What this PR does / why we need it:

The px-operator should not assume the K8s cluster is running a default domain .svc.cluster.local

FIX:

  • as a fix, we will use portworx-api.<namespace> hostname
  • this relies on /etc/resolv.conf to supply search <domain> statements

Which issue(s) this PR fixes (optional)
Closes # PWX-32899 (part 1)

Also PWX-36817 (<< dedicated ticket)

Special notes for your reviewer:

Tested manually on a K8s cluster with modified DNS domain -- Px still deploys correctly, and no significant errors observed in operator's log.

Note also that the plugin @.../component/plugin.go still uses the .svc.cluster.local default DNS domain

  • this DNS-domain was not changed, since plugin works on OCP, and OCP does not offer modification of DNS-domain as a part of the install process

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92c4cd6) 75.85% compared to head (26c9e4c) 75.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1437   +/-   ##
=======================================
  Coverage   75.85%   75.85%           
=======================================
  Files          66       66           
  Lines       19017    19017           
=======================================
  Hits        14426    14426           
  Misses       3563     3563           
  Partials     1028     1028           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Zoran Rajic <zrajic@purestorage.com>
@zoxpx zoxpx force-pushed the PWX-32899_pt1_k8s-dns-fix branch from 9c7f245 to 26c9e4c Compare February 9, 2024 04:23
@zoxpx
Copy link
Collaborator Author

zoxpx commented Feb 9, 2024

Thanks for the review Piyush --

  • merging this PR as it's not requiring other changes (i.e. no vendor-dependencies)
  • currently not cherry-picking to any older releases

@zoxpx zoxpx merged commit 4e68c36 into master Feb 9, 2024
9 checks passed
@zoxpx zoxpx deleted the PWX-32899_pt1_k8s-dns-fix branch February 9, 2024 18:22
@zoxpx zoxpx changed the title PWX-32899_pt1: K8s DNS domain fix PWX-36817/PWX-32899_pt1: K8s DNS domain fix Apr 9, 2024
@zoxpx
Copy link
Collaborator Author

zoxpx commented Apr 9, 2024

Requested cherry-pick to operator-24.1.0 branch

zoxpx added a commit that referenced this pull request Apr 9, 2024
Signed-off-by: Zoran Rajic <zrajic@purestorage.com>

Manually fixed Conflicts:
	drivers/storage/portworx/util/util.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants