[PWX-36110] Cherry-Pick Stork KubeSchedulerConfig changes #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-23.10.4 #1445 +/- ##
================================================
Coverage 79.79% 79.79%
================================================
Files 60 60
Lines 17687 17721 +34
================================================
+ Hits 14113 14141 +28
- Misses 2584 2588 +4
- Partials 990 992 +2 ☔ View full report in Codecov by Sentry. |
olavangad-px
changed the title
olavangad-px
added a commit
that referenced
this pull request
Feb 14, 2024
* Update KubeSchedulerConfiguration to api v1 for k8s version 1.25+ * Addressing comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Omkar Lavangad olavangad@purestorage.com
What this PR does / why we need it:
KubeSchedulerConfiguration v1beta3 is deprecated in v1.26 and is removed in v1.29. We must migrate to KubeSchedulerConfiguration to v1.
This PR is to cherry-pick the changes made as part of #1395 to 23.10.4 release branch
Which issue(s) this PR fixes (optional)
Closes PWX-36110, PWX-35604
Special notes for your reviewer:
These changes have already been reviewed in #1395 .
Here, I am only cherry-picking the required commits (not the entire squashed commit because it was slightly modified when resolving conflicts with master branch)
Testing Details
Have verified with custom image locally that changes are working as expected.
Config map is updated in existing setup (k8s v1.27.2) when operator is upgraded and existing workloads are not rescheduled.