PWX-35633 : Don't allow overriding storage PDB value to more than number of storagenodes #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svijaykumar-px
changed the title
svijaykumar-px
changed the title
|
The ticket here is to avoid quorum loss. The minAvailable number should not be lower than |
The ticket mentions that the minAvailable value should not be greater than quorum number of nodes. Should I include the check to ensure it does not go below n/2+1 as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: As a part of PWX-34411, PDB value for px-storage can be overridden using an annotation, but when the value is greater than or equal to total storage nodes, it prevents upgrades from happening as allowed disruptions becomes 0. This PR ensures than if the annotation value is greater than or equal to total storage nodes, then the default calculation for pdb is used.
Which issue(s) this PR fixes (optional)
Closes # PWX-35633