[PWX-37088] Cherry-picking Stork-Config changes #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on 1.25+ (#1395) * Update KubeSchedulerConfiguration to api v1 for k8s version 1.25+ * Addressing comments
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-24.1.0 #1536 +/- ##
==================================================
- Coverage 80.30% 80.01% -0.30%
==================================================
Files 60 60
Lines 17824 17854 +30
==================================================
- Hits 14314 14286 -28
- Misses 2523 2578 +55
- Partials 987 990 +3 ☔ View full report in Codecov by Sentry. |
nikolaypopov
approved these changes
Apr 30, 2024
nikita-bhatia
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Omkar Lavangad olavangad@purestorage.com
What this PR does / why we need it:
KubeSchedulerConfiguration v1beta3 is deprecated in v1.26 and is removed in v1.29. We must migrate to KubeSchedulerConfiguration to v1.
This PR is to cherry-pick the changes made as part of #1395 to 24.1.0 release branch
Which issue(s) this PR fixes (optional)
Closes PWX-37088, PWX-37080, PWX-35604
Special notes for your reviewer:
These changes have already been reviewed in #1395 and merged in 23.10.4 branch.
Here, I have cherry-picked the changes from master branch.
Also, since Zoran merged after me in 23.10.4 there were some extra changes introduced in these files.
I have added them in this PR as well in the second commit to keep it uniform with 23.10.4
Testing Details
Have verified with custom image locally that changes are working as expected in cluster with k8s version 1.29.0