[Cherry-pick]: Cherry-pick of PR #1587 #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-24.1.1 #1589 +/- ##
===============================================
Coverage 80.23% 80.23%
===============================================
Files 61 61
Lines 18227 18227
===============================================
Hits 14625 14625
Misses 2582 2582
Partials 1020 1020 ☔ View full report in Codecov by Sentry. |
svijaykumar-px
added a commit
that referenced
this pull request
Aug 8, 2024
svijaykumar-px
added a commit
that referenced
this pull request
Aug 8, 2024
* [Cherry-pick ]: Cherry-pick of PR #1275 (#1577) * added validate for storage and cloudstorage spec * Updated Unit tests and validation * modified validate function Conflicts: pkg/controller/storagecluster/controller_test.go * validation to pass UTs * changed storage spec logic and added UT Conflicts: pkg/controller/storagecluster/controller_test.go * removed extra comments * removed extra comments * Update storagecluster.go error statements * Update controller_test.go error messages * correcting go fmt error * update components when autoupdatecomponents is set (#1589) * [Cherry-pick]: Cherry-pick of PR #1355 into 24.1.1 (#1579) * added priorityclassname to stc crd * Added UTs * modified UT Conflicts: pkg/controller/storagecluster/controller_test.go * reverting unecessary change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Cherry of PR #1587 into release-24.1.1