Skip to content

Commit

Permalink
typo
Browse files Browse the repository at this point in the history
  • Loading branch information
guillaumemichel committed Jun 14, 2023
1 parent 6a49f63 commit ced3b1c
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions table.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,11 @@ func (rt *RoutingTable) NPeersForCpl(cpl uint) int {
}
}

// UsefullNewPeer verifies whether the given peer.ID would be a good fit for the
// UsefulNewPeer verifies whether the given peer.ID would be a good fit for the
// routing table. It returns true if the peer isn't in the routing table yet, if
// the bucket corresponding to peer.ID isn't full, if it contains replaceable
// peers or if it is the last bucket and adding a peer would unfold it.
func (rt *RoutingTable) UsefullNewPeer(p peer.ID) bool {
func (rt *RoutingTable) UsefulNewPeer(p peer.ID) bool {
rt.tabLock.RLock()
defer rt.tabLock.RUnlock()

Expand Down
22 changes: 11 additions & 11 deletions table_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -135,60 +135,60 @@ func TestUsefulNewPeer(t *testing.T) {

// add first peer to bucket 0
p, _ := rt.GenRandPeerID(0)
require.True(t, rt.UsefullNewPeer(p))
require.True(t, rt.UsefulNewPeer(p))
rt.TryAddPeer(p, true, false)
// first peer shouldn't be useful, as it is already in the rt
require.False(t, rt.UsefullNewPeer(p))
require.False(t, rt.UsefulNewPeer(p))

// add second peer to bucket 0
p, _ = rt.GenRandPeerID(0)
require.True(t, rt.UsefullNewPeer(p))
require.True(t, rt.UsefulNewPeer(p))
rt.TryAddPeer(p, true, false)

// bucket 0 (also last bucket) full with non replaceable peers
p, _ = rt.GenRandPeerID(0)
require.False(t, rt.UsefullNewPeer(p))
require.False(t, rt.UsefulNewPeer(p))

// bucket 0 is full, unfolding it
// add first peer to bucket 1
p, _ = rt.GenRandPeerID(1)
require.True(t, rt.UsefullNewPeer(p))
require.True(t, rt.UsefulNewPeer(p))
rt.TryAddPeer(p, true, false)

// add second peer to bucket 1
// cpl is 2, but bucket 1 is last bucket
p, _ = rt.GenRandPeerID(2)
require.True(t, rt.UsefullNewPeer(p))
require.True(t, rt.UsefulNewPeer(p))
rt.TryAddPeer(p, true, false)

// unfolding bucket 1
// adding second peer to bucket 2
p, _ = rt.GenRandPeerID(2)
require.True(t, rt.UsefullNewPeer(p))
require.True(t, rt.UsefulNewPeer(p))
rt.TryAddPeer(p, true, false)

// adding replaceable peer to bucket 1
// bucket 1 size: 1 -> 2
p, _ = rt.GenRandPeerID(1)
require.True(t, rt.UsefullNewPeer(p))
require.True(t, rt.UsefulNewPeer(p))
rt.TryAddPeer(p, true, true)

// adding replaceable peer to bucket 1
// bucket 1 size: 2 -> 2
p, _ = rt.GenRandPeerID(1)
require.True(t, rt.UsefullNewPeer(p))
require.True(t, rt.UsefulNewPeer(p))
rt.TryAddPeer(p, true, true)

// adding non replaceable peer to bucket 1
// bucket 1 size: 2 -> 2
p, _ = rt.GenRandPeerID(1)
require.True(t, rt.UsefullNewPeer(p))
require.True(t, rt.UsefulNewPeer(p))
rt.TryAddPeer(p, true, false)

// adding non replaceable peer to bucket 1
// bucket 1 size: 2 -> 2
p, _ = rt.GenRandPeerID(1)
require.False(t, rt.UsefullNewPeer(p))
require.False(t, rt.UsefulNewPeer(p))
rt.TryAddPeer(p, true, false)
}

Expand Down

0 comments on commit ced3b1c

Please sign in to comment.