Add host with circuitv2 to integration test #3162
Conversation
p2p/test/transport/transport_test.go
Outdated
| func TestConnRelay(t *testing.T) { | ||
| for _, tc := range transportsToTest { | ||
| if tc.Name != RelayTestOnTransportName { | ||
| continue |
There was a problem hiding this comment.
We don't want a separate test for Relay. We want to run all integration tests with a Relay transport.
This package has a bunch of tests that we want all transports to satisfy, like ConnGater Test, ResourceManager Test, PingPong on streams, etc. We should add another transport to the list of already present transports which connects hosts over a circuit relay address.
At the moment it's fine to ignore which underlying transport is used to make the relay connection, and just use QUIC as the underlying transport. Ideally, any problem in the underlying transports should be caught when testing that specifc transport.
| var transportsToTest = []TransportTestCase{ | ||
| { |
There was a problem hiding this comment.
Add another item to this list with Name: "circuit-v2"
p2p/test/transport/transport_test.go
Outdated
| if opts.EnabledRelay { | ||
| libp2pOpts = append(libp2pOpts, libp2p.EnableRelay(), libp2p.EnableRelayService()) | ||
| } |
There was a problem hiding this comment.
It's better to just run the relay test separately. Where the dialer and the listener are both using p2p-circuit to connect.
Description
circuitv2to transport integration test