Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use cc-debian12 base image for interop tests #5120

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Jan 24, 2024

Description

With the update to Rust 1.73, we need glibc > 3.32 which is not available in the regular cc base image.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger changed the title fix: update distroless/cc image to be based on debian-12 to update glibc fix: statically link test binaries Jan 24, 2024
@thomaseizinger thomaseizinger force-pushed the fix/wrong-glibc-version branch from ef97ef9 to 8f66ad6 Compare January 24, 2024 17:14
@thomaseizinger thomaseizinger changed the title fix: statically link test binaries fix: use cc-debian12 base image for interop tests Jan 24, 2024
@thomaseizinger thomaseizinger marked this pull request as ready for review January 24, 2024 17:17
@thomaseizinger
Copy link
Contributor Author

This is working, see libp2p/test-plans#342.

@thomaseizinger thomaseizinger merged commit f1bfe8d into v0.52 Jan 24, 2024
108 of 141 checks passed
@thomaseizinger thomaseizinger deleted the fix/wrong-glibc-version branch January 24, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant