feat(swarm): remove deprecated with_bandwidth_logging

[drHuangMHT]

Description

Remove deprecated(since 0.53.0) bandwidth logging code:

rust-libp2p/libp2p/CHANGELOG.md

Lines 71 to 73 in 644d7d0

	- Introduce `SwarmBuilder::with_bandwidth_metrics` exposing Prometheus bandwidth metrics per transport protocol stack and direction (in-/ outbound).
	Deprecate `Transport::with_bandwidth_logging` and `SwarmBuilder::with_bandwidth_logging` in favor of the new `SwarmBuilder::with_bandwidth_metrics`.
	See [PR 4727](https://github.com/libp2p/rust-libp2p/pull/4727).

related: #4727

Notes & open questions

In order to remove BandwidthSinks

rust-libp2p/libp2p/src/bandwidth.rs

Lines 107 to 113 in 644d7d0

	#[deprecated(
	note = "Use `libp2p::SwarmBuilder::with_bandwidth_metrics` or `libp2p_metrics::BandwidthTransport` instead."
	)]
	pub struct BandwidthSinks {
	inbound: AtomicU64,
	outbound: AtomicU64,
	}

the entire module needs to be removed along with libp2p::TransportExt. They can all be removed safely but libp2p::TransportExt does not have a deprecation warning yet. Should this be put off to the future release?

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• A changelog entry has been made in the appropriate crates

[elenaf9]

IMO removing TransportExt without a deprecation warning is okay.

I can't think if any use-case where a user would implement it for a type in the first place, and using it as a trait-bound doesn't make sense anymore if when it's only method with_bandwidth_logging is removed.

[drHuangMHT]

cc @jxs

[drHuangMHT]

cc @dariusc93

[elenaf9]

IMO removing TransportExt without a deprecation warning is okay.

Expanding on this: I think it is okay because TransportExt only has this single method with_bandwidth_logging that has been deprecated for some time now. So any user of it will have been informed of it's deprecation.

We usually first deprecate items before removing them to allow a transition period where users can upgrade their version and then eventually move await from using the deprecated items (which may require some time/ effort). However in this specific case, TransportExt won't be of any use after it's only method is removed.

What we could do is first deprecate TransportExt, release, and then merge this PR.

[elenaf9]

LGTM. Just missing a CHANGELOG entry and version bump :)

[drHuangMHT]

LGTM. Just missing a CHANGELOG entry and version bump :)

That will be a major version bump in order to pass semver, is that acceptable?

[elenaf9]

That will be a major version bump in order to pass semver, is that acceptable?

Yes. #5861 will require a major bump anyway.

[drHuangMHT]

cc @jxs

[elenaf9]

Suggested change

	- Remove deprecated `Transport::with_bandwidth_logging`, `SwarmBuilder::with_bandwidth_logging` and `TransportExt`.
	See [PR 5766](https://github.com/libp2p/rust-libp2p/pull/5766).
	## 0.55.1
	- Introduce `libp2p-webrtc-websys` behind `webrtc-websys` feature flag.
	See [PR 5819](https://github.com/libp2p/rust-libp2p/pull/5819).
	- Introduce `libp2p-webrtc-websys` behind `webrtc-websys` feature flag.
	See [PR 5819](https://github.com/libp2p/rust-libp2p/pull/5819).
	- Remove deprecated `Transport::with_bandwidth_logging`, `SwarmBuilder::with_bandwidth_logging` and `TransportExt`.
	See [PR 5766](https://github.com/libp2p/rust-libp2p/pull/5766).

v0.55.1 hasn't been released, so the CHANGELOG entries should be merged.

[drHuangMHT]

Are we releasing 0.56 very soon?

[elenaf9]

Depends. Is there specific need for it?
If someone needs libp2p-webrtc-websys we can also just do an individual release for that crate.

[drHuangMHT]

Depends. Is there specific need for it?

This PR? No, this one is quite low priority.