Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(yamux): migrate tests from async-std to tokio #5872

Conversation

shiyasmohd
Copy link
Contributor

@shiyasmohd shiyasmohd commented Feb 19, 2025

Description

Migrating tests in libp2p-yamux from async_std to tokio as per #4449

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

elenaf9
elenaf9 previously approved these changes Feb 20, 2025
jxs
jxs previously approved these changes Feb 20, 2025
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jxs jxs added the send-it label Feb 20, 2025
@mergify mergify bot dismissed stale reviews from jxs and elenaf9 February 20, 2025 14:56

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@mergify mergify bot merged commit 9e0e8be into libp2p:master Feb 20, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants