Add true streaming #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandlo
force-pushed
the
add-true-streaming
branch
from
590afda to
7d6cd79
Compare
|
This is very cool! The custom source / target classes would need the Signals are handy for other stuff --- pyvips exposes the progress signals, so you can have |
rolandlo
force-pushed
the
add-true-streaming
branch
from
b81afde to
1bc305d
Compare
rolandlo
changed the title
rolandlo
force-pushed
the
add-true-streaming
branch
from
1bc305d to
0895fd2
Compare
rolandlo
force-pushed
the
add-true-streaming
branch
5 times, most recently
from
1efbfce to
5a84eca
Compare
rolandlo
force-pushed
the
add-true-streaming
branch
from
8a11241 to
fb53bea
Compare
This commit allows creating image sources from descriptor, file or memory and image targets to descriptor, file or memory. Custom classes are not implemented
rolandlo
force-pushed
the
add-true-streaming
branch
from
fb53bea to
cbeb119
Compare
|
@rolandlo sorry, I'm travelling this week, I've not had a chance to do any work. Your README update looks fine, and nice job! |
Thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are currently restricted to writing to a file target. The script
example/target.luawrites to stdout.An illegal machine instruction issue with that script using Lua 5.4 has been solved by stopping/restarting garbage collection in
Target.new_to_*.Tests are still missing.The scriptexample/target.luaworks with luajit and Lua 5.1, 5.2 and 5.3, but crashes with Lua 5.4 due to illegal machine instruction.