Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump LLVM #988

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Bump LLVM #988

merged 4 commits into from
Dec 10, 2024

Conversation

adam-smnk
Copy link
Contributor

Fixes after bump:

  • Update IR syntax
  • Resolve broken implicit conversions when initializing pass options
  • Remove deprecated partial bufferization
  • Fix APInt ctor assertion - use zero for undefined length vector read

@adam-smnk adam-smnk added the benchmark Benchmark base targets label Dec 3, 2024
@adam-smnk adam-smnk force-pushed the bump-llvm-24-dec-03 branch from 7e2e62d to 060b39d Compare December 4, 2024 11:04
@adam-smnk adam-smnk added benchmark Benchmark base targets and removed benchmark Benchmark base targets labels Dec 4, 2024
@rengolin
Copy link
Contributor

rengolin commented Dec 4, 2024

Unless there's an urgent need to fix these issues, let's wait until #980 and #987 are merged.

@adam-smnk
Copy link
Contributor Author

No rush, we're just pretty outdated.

@adam-smnk
Bump LLVM
7bcde6e 
Fixes after bump:
  - Update IR syntax
  - Resolve broken implicit conversions when initializing pass options
  - Remove deprecated partial bufferization
  - Fix APInt ctor assertion - use zero for undefined length vector read
@adam-smnk
Bump after rebase
3eea3ce
@adam-smnk
Update error message
160ae9e
@adam-smnk
Copy link
Contributor Author

Rebased + solved conflicts, bumped again + updated error message

@adam-smnk adam-smnk merged commit d7fcc28 into libxsmm:main Dec 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rengolin rengolin rengolin approved these changes

@rolfmorel rolfmorel Awaiting requested review from rolfmorel

@KavithaTipturMadhu KavithaTipturMadhu Awaiting requested review from KavithaTipturMadhu

@shahidact shahidact Awaiting requested review from shahidact

@arun-thmn arun-thmn Awaiting requested review from arun-thmn

Assignees
No one assigned
Labels
benchmark Benchmark base targets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adam-smnk @rengolin