-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPD-46157 Create Icon Selector (No Keyboard Interactions) #5929
Draft
ilzamcmed
wants to merge
2
commits into
liferay:master
Choose a base branch
from
ilzamcmed:LPD-46157
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilzamcmed
changed the title
Create Icon Selector (No Keyboard Interactions)
LPD-46157 Create Icon Selector (No Keyboard Interactions)
Jan 27, 2025
Hey @matuzalemsteles, this is the inicial commits for the icon selector component. |
ilzamcmed
force-pushed
the
LPD-46157
branch
3 times, most recently
from
January 28, 2025 18:04
e830590
to
037661f
Compare
…display items on a grid, filter options and select an icon
…t and it's imports
ethib137
requested changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ilza!
ethib137
reviewed
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-46157
This pull request is a draft. As this is a new component, I will submit changes in stages to facilitate review.
Below there's a video of the component working.
I haven't worked on styles yet.
simplescreenrecorder-2025-01-27_17.05.24.mp4