-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gridded data #133
Open
cparcerisas
wants to merge
16
commits into
main
Choose a base branch
from
feature/gridded_data
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/gridded data #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@carueda Do you want to give it a go to testing if the gridded implementation works? |
…ration type is not compatible
…els from acoustic_chunk
…ration type is not compatible
…els from acoustic_chunk
…ypam into feature/gridded_data
Feature/save daily files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the way some things are computed so we can have "gridded" data. This means that the seconds are at zero for all the bins, and that pypam will look for the next file in line to join the end and the beginning of the two files.
This is currently done only if there is a gap of less than 1 second between timestamp of the second file and end of the first one.
For this, I added a class acoustic_chunk so it can represent each bin.
In the future all the binsize and bin_overlap parameters should be changed to chunksize and chunk_overlap for clarity.
Still some things to be polished so code is more elegant and things are not repeated.