Fix spammy reconnection logs #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We periodically try to reconnect to known persisted peers, but so far every 10 seconds, which resulted in very spammy reconnection logs. Here, we bump the reconnection interval to once a minute, which is still pretty low.
We already log connection attempts in `do_connect_peer`, so no need to additionally log them just to note it's a reconnection.
It can be very useful to see which tasks end up delaying shutdown. Therefore, we here bump their logging from `TRACE` to `DEBUG`.
arik-so
reviewed
Feb 5, 2025
There was a problem hiding this comment.
does this have the potential to make it more difficult for people to understand why a reconnection is occurring?
There was a problem hiding this comment.
I think it shouldn't change the status quo in any direction I think, it just gets rid of redundantly logged lines that didn't hold any additional information really.
arik-so
approved these changes
Feb 6, 2025
|
CI seems to have been cancelled, but not due to test failure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We periodically try to reconnect to known persisted peers, but so far every 10 seconds, which resulted in very spammy reconnection logs. Here, we bump the reconnection interval to once a minute, which is still pretty low.
We also drop redundant reconnection logging as we already log connection attempts in
do_connect_peer, so no need toadditionally log them just to note it's a reconnection.