Add a funding_value field in channel_announcements #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
TheBlueMatt
force-pushed
the
2024-11-val-field
branch
2 times, most recently
from
a705b9d to
5c75fdf
Compare
|
Oops, fixed tests. |
TheBlueMatt
force-pushed
the
2024-11-val-field
branch
2 times, most recently
from
d8fa532 to
b90ce44
Compare
arik-so
reviewed
Dec 2, 2024
|
Pushed fixups for the issues. Let me know if I should squash. |
|
Yes, please squash and looks good |
|
Cool, done. |
TheBlueMatt
force-pushed
the
2024-11-val-field
branch
from
b90ce44 to
29dfeb8
Compare
arik-so
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be useful for RGSS in the future but for now its useful for stats generation.