Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate v1 and v2 dummy snapshots #88

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

arik-so
Copy link
Contributor

@arik-so arik-so commented Jan 31, 2025

Previously, our dummy snapshots were unversioned. This commit ensures that we generate no-op serializations for both currently supported versions, and introduces unit tests to ascertain their validity.

Previously, our dummy snapshots were unversioned. This commit ensures
that we generate no-op serializations for both currently supported
versions, and introduces unit tests to ascertain their validity.
@arik-so arik-so requested review from TheBlueMatt and tnull January 31, 2025 19:35
Copy link
Contributor

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearly not worse than it was :)

@TheBlueMatt TheBlueMatt merged commit 1e54c9c into lightningdevkit:main Jan 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants