Skip to content

feat: clarifying the descriptions of user_id and DESTINATION_USER_ID … #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Maimikuru
Copy link

@Maimikuru Maimikuru commented Apr 30, 2025

Resolve this issue

This pull request updates the documentation in both Japanese (README.ja.md) and English (README.md) to clarify the requirements for setting user_id and DESTINATION_USER_ID in various contexts. The changes ensure that users understand that at least one of these values must be specified.

Documentation Updates:

Clarifications on user_id and DESTINATION_USER_ID Requirements:

  • Updated descriptions in the push_text_message, push_flex_message, and get_profile sections to specify that either user_id or DESTINATION_USER_ID must be set. (README.ja.md: [1] [2]; README.md: [3]
  • Modified the description of the DESTINATION_USER_ID environment variable to clarify that it is optional but either it or user_id must be set. (README.ja.md: [1]; README.md: [2]

@CLAassistant
Copy link

CLAassistant commented Apr 30, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@eucyt eucyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your cooperation. I believe this is an important revision for a clear and understandable README.

Maimikuru and others added 4 commits May 1, 2025 14:28
Co-authored-by: Yuta Euchi <63095160+eucyt@users.noreply.github.com>
Co-authored-by: Yuta Euchi <63095160+eucyt@users.noreply.github.com>
@@ -35,8 +35,8 @@ LINE公式アカウントとAI Agentを接続するために、LINE Messaging AP
- `message.contents.type` (enum): コンテナのタイプ。'bubble'は単一コンテナ、'carousel'は複数のスワイプ可能なバブルを示す。
5. **get_profile**
- LINEユーザーの詳細なプロフィール情報を取得する。表示名、プロフィール画像URL、ステータスメッセージ、言語を取得できる。
- **Inputs:**
- `user_id` (string?): プロフィールを取得したいユーザーのユーザーID。デフォルトはDESTINATION_USER_ID。
- **入力:**
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eucyt
I also found other places that were not in Japanese, so I have corrected them.

@@ -56,7 +56,7 @@ Claude DesktopやClaudeなどのAI Agentに次の設定を追加してくださ
環境変数や引数は次のように設定してください:

- `CHANNEL_ACCESS_TOKEN`: (必須) チャネルアクセストークン。これを取得するには、[こちらの手順](https://developers.line.biz/ja/docs/basics/channel-access-token/#long-lived-channel-access-token)に従ってください。
- `DESTINATION_USER_ID`: (オプション) デフォルトのメッセージ受信者のユーザーID。これを確認するには、[こちらの手順](https://developers.line.biz/ja/docs/messaging-api/getting-user-ids/#get-own-user-id)に従ってください。
- `DESTINATION_USER_ID`: (オプション) デフォルトのメッセージ受信者のユーザーID。Toolの入力に`user_id`が含まれていない場合、`DESTINATION_USER_ID`は必ず設定する必要があります。これを確認するには、[こちらの手順](https://developers.line.biz/ja/docs/messaging-api/getting-user-ids/#get-own-user-id)に従ってください。
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eucyt
I have changed the wording.
This is because an error occurs when the tool's input does not include user_id and DESTINATION_USER_ID is not set.

@Maimikuru Maimikuru requested a review from eucyt May 1, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants