Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix build in nextjs example #2152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

timofei-iatsenko
Copy link
Collaborator

Description

this one supersede #2146

Turned out that dev worked, but build not. So some alignments had to be done to make build work without errors.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Jan 17, 2025 11:19am

@timofei-iatsenko timofei-iatsenko changed the title examples: update nextjs example. Fix build docs: fix build in nextjs example Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

size-limit report 📦

Path Size
packages/core/dist/index.mjs 2.91 KB (0%)
packages/detect-locale/dist/index.mjs 618 B (0%)
packages/react/dist/index.mjs 1.37 KB (0%)

Comment on lines 1 to +2
import { HomePage } from '../../../components/HomePage'
import { initLingui } from '../../../initLingui'
import { initLingui, PageLangParam } from "../../../initLingui"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the quote format consistent here and in a few other places below. Some imports use ", some '

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, it should be covered by prettier, why it doesn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants